[Metrics] Pod OTEL metrics table: review follow-ups from #259552#262708
Merged
rmyz merged 2 commits intoelastic:mainfrom Apr 14, 2026
Merged
[Metrics] Pod OTEL metrics table: review follow-ups from #259552#262708rmyz merged 2 commits intoelastic:mainfrom
rmyz merged 2 commits intoelastic:mainfrom
Conversation
Hoist unpackRow in calculateMetricAverages, use for..of and const for averages per jennypavlova review on elastic#259552. Guard working_set byte conversion with Number.isFinite before dividing to MB, per review question on elastic#259552. Related: elastic#259552 Made-with: Cursor
rmyz
added
release_note:skip
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @rmyz |
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
Contributor
ApprovabilityVerdict: Needs human review This PR contains mechanical refactoring (loop style, variable destructuring, ternary expressions) and adds a defensive Number.isFinite check. While the changes are low-risk code cleanup, the author does not own this file which is explicitly owned by @elastic/obs-presentation-team, warranting review by the designated owners. You can customize Macroscope's approvability policy. Learn more. |
miloszmarcinkowski
approved these changes
Apr 13, 2026
Contributor
miloszmarcinkowski
left a comment
miloszmarcinkowski
left a comment
There was a problem hiding this comment.
LGTM, tested locally
Contributor
|
Starting backport for target branches: 8.19, 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/24385315870 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 14, 2026
… (elastic#262708) (cherry picked from commit 79208d3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 14, 2026
… (elastic#262708) (cherry picked from commit 79208d3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 14, 2026
… (elastic#262708) (cherry picked from commit 79208d3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 14, 2026
#262708) (#262939) # Backport This will backport the following commits from `main` to `9.3`: - [[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)](#262708) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2026-04-14T06:53:29Z","message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.4.0","Team:obs-presentation","v9.5.0","v9.3.4","v8.19.15"],"title":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552","number":262708,"url":"https://github.com/elastic/kibana/pull/262708","mergeCommit":{"message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3","8.19"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/262708","number":262708,"mergeCommit":{"message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78"}},{"branch":"9.3","label":"v9.3.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.15","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Apr 14, 2026
#262708) (#262940) # Backport This will backport the following commits from `main` to `9.4`: - [[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)](#262708) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2026-04-14T06:53:29Z","message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.4.0","Team:obs-presentation","v9.5.0","v9.3.4","v8.19.15"],"title":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552","number":262708,"url":"https://github.com/elastic/kibana/pull/262708","mergeCommit":{"message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3","8.19"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/262708","number":262708,"mergeCommit":{"message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78"}},{"branch":"9.3","label":"v9.3.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.15","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Apr 14, 2026
… (#262708) (#262938) # Backport This will backport the following commits from `main` to `8.19`: - [[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)](#262708) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2026-04-14T06:53:29Z","message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.4.0","Team:obs-presentation","v9.5.0","v9.3.4","v8.19.15"],"title":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552","number":262708,"url":"https://github.com/elastic/kibana/pull/262708","mergeCommit":{"message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3","8.19"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/262708","number":262708,"mergeCommit":{"message":"[Metrics] Pod OTEL metrics table: review follow-ups from #259552 (#262708)","sha":"79208d3e820bebbfb5de90863b039c949c551d78"}},{"branch":"9.3","label":"v9.3.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.15","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
tfcmarques
pushed a commit
to tfcmarques/kibana
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to review feedback on #259552 (discussion).
unpackRow(unpackMetricsOtelvsunpackMetrics) outside the row loop, usefor..ofwith destructuring, and express CPU/memory averages withconstternaries (@jennypavlova).memory.working_setto MB when the unpacked value is a finitenumber, avoiding bad division on unexpected types (@jennypavlova).Release note
Skip — small refactor / defensive check in an internal metrics path.
Risk
Low. Behavior unchanged for valid numeric OTLP payloads; invalid values map to
nullfor MB instead ofNaN.